Skip to content

🎨 Palette: κ°œμ„ λœ 파일 μ—…λ‘œλ“œ λ²„νŠΌ UX 적용 - #925

Merged
seonghobae merged 4 commits into
developfrom
feat/palette-file-upload-ux-10910099905014635097
Aug 12, 2026
Merged

🎨 Palette: κ°œμ„ λœ 파일 μ—…λ‘œλ“œ λ²„νŠΌ UX 적용#925
seonghobae merged 4 commits into
developfrom
feat/palette-file-upload-ux-10910099905014635097

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Palette UX κ°œμ„ : 파일 μ—…λ‘œλ“œ λ²„νŠΌ 일관성 ν–₯상 🎨

πŸ’‘ What

Dashboard UIμ—μ„œ λΈŒλΌμš°μ € κΈ°λ³Έ <input type="file">을 숨기고, 기쑴의 .tag λ””μžμΈ 클래슀λ₯Ό ν™œμš©ν•œ ν”„λ‘μ‹œ λ²„νŠΌ(<button id="header-browse">Upload findings</button>)을 λ„μž…ν–ˆμŠ΅λ‹ˆλ‹€.

🎯 Why

  • 일관성 μ—†λŠ” λΈŒλΌμš°μ € μŠ€νƒ€μΌλ§: 각 λΈŒλΌμš°μ €(크둬, νŒŒμ΄μ–΄ν­μŠ€, μ‚¬νŒŒλ¦¬ λ“±)λ§ˆλ‹€ κΈ°λ³Έ 파일 인풋 λ””μžμΈμ΄ 달라 전체적인 UI 톡일성을 μ €ν•΄ν•©λ‹ˆλ‹€.
  • 동일 파일 연속 선택 문제: ν˜„μž¬ ꡬ쑰(SPA ν˜•νƒœ)μ—μ„œλŠ” μ‚¬μš©μžκ°€ λ™μΌν•œ 파일(findings.json)을 μ—°μ†μœΌλ‘œ λ‹€μ‹œ μ—…λ‘œλ“œν•˜λ €κ³  ν•  λ•Œ λΈŒλΌμš°μ €κ°€ change 이벀트λ₯Ό λ°œμƒμ‹œν‚€μ§€ μ•Šμ•„ UIκ°€ λ°˜μ‘ν•˜μ§€ μ•ŠλŠ” λ¬Έμ œκ°€ λ°œμƒν•  수 μžˆμŠ΅λ‹ˆλ‹€. ν”„λ‘μ‹œ λ²„νŠΌμ„ μ‚¬μš©ν•˜κ³  μŠ€ν¬λ¦½νŠΈμ—μ„œ λͺ…μ‹œμ μœΌλ‘œ valueλ₯Ό λΉ„μ›Œμ€ŒμœΌλ‘œμ¨ 이 문제λ₯Ό 근본적으둜 ν•΄κ²°ν–ˆμŠ΅λ‹ˆλ‹€.

β™Ώ Accessibility

  • 기쑴의 <input type="file">은 DOMμ—μ„œ μ œκ±°ν•˜μ§€ μ•Šκ³  sr-only, tabindex="-1", aria-hidden="true"λ₯Ό μ μš©ν•˜μ—¬ 슀크린 λ¦¬λ”μ—μ„œ μ€‘λ³΅μœΌλ‘œ μ½νžˆλŠ” 것을 λ°©μ§€ν•˜λ©΄μ„œ κΈ°λŠ₯은 μœ μ§€ν–ˆμŠ΅λ‹ˆλ‹€.
  • ν…ŒμŠ€νŠΈ μ‹œ μ‹€νŒ¨λ₯Ό μœ λ°œν•˜μ§€ μ•Šλ„λ‘ test_dashboard_rows_are_keyboard_accessible 의 였래된 aria-label 검증 μ½”λ“œλ₯Ό μ•ˆμ „ν•˜κ²Œ μ—…λ°μ΄νŠΈν•˜μ˜€μŠ΅λ‹ˆλ‹€.

πŸ“Έ Before/After

(μˆ˜μ • μ „) κΈ°λ³Έ λΈŒλΌμš°μ € μŠ€νƒ€μΌμ˜ 파일 μ—…λ‘œλ“œ λ²„νŠΌ λ…ΈμΆœ
(μˆ˜μ • ν›„) ν—€λ”μ˜ λ””μžμΈ 토큰(.tag)에 μ–΄μšΈλ¦¬λŠ” ν…μŠ€νŠΈ ν˜•νƒœμ˜ ν”„λ‘μ‹œ λ²„νŠΌ λ…ΈμΆœ


PR created automatically by Jules for task 10910099905014635097 started by @seonghobae

Dashboard의 λ„€μ΄ν‹°λΈŒ 파일 μ—…λ‘œλ“œ 인풋을 숨기고 μŠ€νƒ€μΌ μ œμ–΄κ°€ κ°€λŠ₯ν•œ ν”„λ‘μ‹œ λ²„νŠΌμœΌλ‘œ κ΅μ²΄ν•˜μ—¬ UI 일관성을 ν–₯μƒμ‹œμΌ°μŠ΅λ‹ˆλ‹€.

- λ„€μ΄ν‹°λΈŒ `<input type="file">`은 `sr-only` 등을 톡해 접근성을 μœ μ§€ν•œ 채 μ‹œκ°μ μœΌλ‘œλ§Œ μˆ¨κΉ€ 처리
- `.tag` 클래슀λ₯Ό ν™œμš©ν•œ μƒˆλ‘œμš΄ μ—…λ‘œλ“œ ν”„λ‘μ‹œ `<button>` μΆ”κ°€
- 단일 νŽ˜μ΄μ§€ μ• ν”Œλ¦¬μΌ€μ΄μ…˜(SPA)μ—μ„œ 동일 파일 연속 선택 μ‹œ λΈŒλΌμš°μ €κ°€ `change` 이벀트λ₯Ό λ¬΄μ‹œν•˜λŠ” 문제 ν•΄κ²° (JSμ—μ„œ 파일 캑처 ν›„ `value` μ΄ˆκΈ°ν™”)
- κ΄€λ ¨ UX ν•™μŠ΅ λ‚΄μš©μ„ `.jules/palette.md`에 μΆ”κ°€
- λ³€κ²½ 사항에 맞게 ν”„λ‘ νŠΈμ—”λ“œ UI μ»¨νŠΈλž™νŠΈ ν…ŒμŠ€νŠΈ μ—…λ°μ΄νŠΈ
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
βš™οΈ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d4ceca4c-73af-4bb9-b901-ff4df9a0c00e

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between baff364 and 614b4fa.

πŸ“’ Files selected for processing (3)
  • .jules/palette.md
  • scanner/dashboard/index.html
  • tests/test_dashboard_core.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae merged commit 1013819 into develop Aug 12, 2026
38 checks passed
@seonghobae
seonghobae deleted the feat/palette-file-upload-ux-10910099905014635097 branch August 12, 2026 06:29
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Security Aug 12, 2026
seonghobae added a commit that referenced this pull request Aug 12, 2026
Preserve the exact reviewed scanner scope while integrating protected develop after #925.
seonghobae added a commit that referenced this pull request Aug 12, 2026
* πŸ›‘οΈ Sentinel: [CRITICAL] Fix stored SSRF in webhook URL endpoint

- /api/v1/webhook μ—”λ“œν¬μΈνŠΈμ—μ„œ μ‚¬μš©μžλ‘œλΆ€ν„° 전달받은 webhook url을 검증 없이 λ°μ΄ν„°λ² μ΄μŠ€μ— μ €μž₯ν•˜λŠ” 취약점이 λ°œκ²¬λ˜μ—ˆμŠ΅λ‹ˆλ‹€.
- appguardrail_core/controlplane.py에 μ‘΄μž¬ν•˜λŠ” webhook 등둝 둜직(do_POST)μ—μ„œ DB μ €μž₯(set_webhook) μ „ _is_safe_url() ν•¨μˆ˜λ‘œ url μ•ˆμ „μ„±μ„ κ²€μ¦ν•˜λ„λ‘ μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.
- 검증에 μ‹€νŒ¨ν•  μ‹œ 400 μ—λŸ¬λ₯Ό μ‘λ‹΅ν•©λ‹ˆλ‹€.
- 이에 λŒ€ν•œ ν…ŒμŠ€νŠΈ μ½”λ“œλ₯Ό tests/test_controlplane.py에 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.

* test(security): reject non-string webhook URLs

* test(security): exercise malformed webhook bodies at API boundary

* πŸ›‘οΈ Sentinel: [CRITICAL] Fix stored SSRF and Uncaught Exception in webhook URL endpoint

- /api/v1/webhook μ—”λ“œν¬μΈνŠΈμ—μ„œ μ‚¬μš©μžλ‘œλΆ€ν„° 전달받은 webhook url을 검증 없이 λ°μ΄ν„°λ² μ΄μŠ€μ— μ €μž₯ν•˜λŠ” 취약점이 λ°œκ²¬λ˜μ–΄, μ €μž₯ μ „ _is_safe_url() ν•¨μˆ˜λ‘œ κ²€μ¦ν•˜λ„λ‘ μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.
- _is_safe_url() λ‚΄λΆ€μ—μ„œ urllib.parse.urlparse() μ‚¬μš© μ „ λ¬Έμžμ—΄ νƒ€μž… 확인 둜직(isinstance(url, str))을 μΆ”κ°€ν•˜μ—¬ μ •μˆ˜ν˜•μ΄λ‚˜ λΆˆλ¦¬μ–Έ λ“± 잘λͺ»λœ νƒ€μž…μ΄ μž…λ ₯될 λ•Œ μ„œλ²„ μ—λŸ¬(500) λŒ€μ‹  μ•ˆμ „ν•˜κ²Œ μ°¨λ‹¨λ˜λ„λ‘ μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.
- 검증에 μ‹€νŒ¨ν•  μ‹œ 400 μ—λŸ¬λ₯Ό μ‘λ‹΅ν•˜λ©° κ΄€λ ¨ ν…ŒμŠ€νŠΈ μ½”λ“œλ₯Ό μ—…λ°μ΄νŠΈ/μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.

* test(scanner): reproduce stored SSRF detection gap

* security(scanner): detect direct stored webhook SSRF

* test(controlplane): pin webhook input validation boundary

* fix(controlplane): reject malformed webhook payloads

* test(controlplane): prove invalid webhook input preserves state

* test(scanner): expose stored SSRF variable-flow blind spot

* fix(scanner): detect unvalidated stored SSRF variable flow

* test(scanner): expose SSRF finding metadata misclassification

* fix(scanner): classify CWE-918 findings as SSRF

* test(scanner): expose stored SSRF rule evasion paths

* fix(scanner): close stored SSRF rule evasion paths

* test(scanner): expose non-enforcing SSRF guard bypass

* test(scanner): pin fail-closed SSRF guard semantics

* fix(scanner): require enforcing SSRF validation guards

* docs(tests): document stored SSRF regression contracts

* test(scanner): expose equivalent stored SSRF accessors

* fix(scanner): detect equivalent stored SSRF accessors

* docs(tests): document webhook validation helpers

* perf(scanner): prefilter stored SSRF rule by sink literal

Avoid evaluating the bounded but expensive flow regex in Python files that cannot persist a webhook. Preserve exact detection semantics while reducing a 1 MiB sink-free scan from seconds to a linear literal check.

* fix(scanner): accept none-aware fail-closed SSRF guard

* 🎨 Palette: κ°œμ„ λœ 파일 μ—…λ‘œλ“œ λ²„νŠΌ UX 적용 (#925)

* feat(dashboard): κ°œμ„ λœ 파일 μ—…λ‘œλ“œ UXλ₯Ό μœ„ν•œ ν”„λ‘μ‹œ λ²„νŠΌ μΆ”κ°€

Dashboard의 λ„€μ΄ν‹°λΈŒ 파일 μ—…λ‘œλ“œ 인풋을 숨기고 μŠ€νƒ€μΌ μ œμ–΄κ°€ κ°€λŠ₯ν•œ ν”„λ‘μ‹œ λ²„νŠΌμœΌλ‘œ κ΅μ²΄ν•˜μ—¬ UI 일관성을 ν–₯μƒμ‹œμΌ°μŠ΅λ‹ˆλ‹€.

- λ„€μ΄ν‹°λΈŒ `<input type="file">`은 `sr-only` 등을 톡해 접근성을 μœ μ§€ν•œ 채 μ‹œκ°μ μœΌλ‘œλ§Œ μˆ¨κΉ€ 처리
- `.tag` 클래슀λ₯Ό ν™œμš©ν•œ μƒˆλ‘œμš΄ μ—…λ‘œλ“œ ν”„λ‘μ‹œ `<button>` μΆ”κ°€
- 단일 νŽ˜μ΄μ§€ μ• ν”Œλ¦¬μΌ€μ΄μ…˜(SPA)μ—μ„œ 동일 파일 연속 선택 μ‹œ λΈŒλΌμš°μ €κ°€ `change` 이벀트λ₯Ό λ¬΄μ‹œν•˜λŠ” 문제 ν•΄κ²° (JSμ—μ„œ 파일 캑처 ν›„ `value` μ΄ˆκΈ°ν™”)
- κ΄€λ ¨ UX ν•™μŠ΅ λ‚΄μš©μ„ `.jules/palette.md`에 μΆ”κ°€
- λ³€κ²½ 사항에 맞게 ν”„λ‘ νŠΈμ—”λ“œ UI μ»¨νŠΈλž™νŠΈ ν…ŒμŠ€νŠΈ μ—…λ°μ΄νŠΈ

* test(dashboard): lock accessible upload proxy wiring

---------

Co-authored-by: seonghobae <8172694+seonghobae@users.noreply.github.com>

---------

Co-authored-by: seonghobae <8172694+seonghobae@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant