π¨ Palette: κ°μ λ νμΌ μ λ‘λ λ²νΌ UX μ μ© - #925
Conversation
Dashboardμ λ€μ΄ν°λΈ νμΌ μ λ‘λ μΈνμ μ¨κΈ°κ³ μ€νμΌ μ μ΄κ° κ°λ₯ν νλ‘μ λ²νΌμΌλ‘ κ΅μ²΄νμ¬ UI μΌκ΄μ±μ ν₯μμμΌ°μ΅λλ€. - λ€μ΄ν°λΈ `<input type="file">`μ `sr-only` λ±μ ν΅ν΄ μ κ·Όμ±μ μ μ§ν μ± μκ°μ μΌλ‘λ§ μ¨κΉ μ²λ¦¬ - `.tag` ν΄λμ€λ₯Ό νμ©ν μλ‘μ΄ μ λ‘λ νλ‘μ `<button>` μΆκ° - λ¨μΌ νμ΄μ§ μ ν리μΌμ΄μ (SPA)μμ λμΌ νμΌ μ°μ μ ν μ λΈλΌμ°μ κ° `change` μ΄λ²€νΈλ₯Ό 무μνλ λ¬Έμ ν΄κ²° (JSμμ νμΌ μΊ‘μ² ν `value` μ΄κΈ°ν) - κ΄λ ¨ UX νμ΅ λ΄μ©μ `.jules/palette.md`μ μΆκ° - λ³κ²½ μ¬νμ λ§κ² νλ‘ νΈμλ UI 컨νΈλνΈ ν μ€νΈ μ λ°μ΄νΈ
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
Next review available in: 52 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review detailsβοΈ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: π Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Preserve the exact reviewed scanner scope while integrating protected develop after #925.
* π‘οΈ Sentinel: [CRITICAL] Fix stored SSRF in webhook URL endpoint - /api/v1/webhook μλν¬μΈνΈμμ μ¬μ©μλ‘λΆν° μ λ¬λ°μ webhook urlμ κ²μ¦ μμ΄ λ°μ΄ν°λ² μ΄μ€μ μ μ₯νλ μ·¨μ½μ μ΄ λ°κ²¬λμμ΅λλ€. - appguardrail_core/controlplane.pyμ μ‘΄μ¬νλ webhook λ±λ‘ λ‘μ§(do_POST)μμ DB μ μ₯(set_webhook) μ _is_safe_url() ν¨μλ‘ url μμ μ±μ κ²μ¦νλλ‘ μμ νμ΅λλ€. - κ²μ¦μ μ€ν¨ν μ 400 μλ¬λ₯Ό μλ΅ν©λλ€. - μ΄μ λν ν μ€νΈ μ½λλ₯Ό tests/test_controlplane.pyμ μΆκ°νμ΅λλ€. * test(security): reject non-string webhook URLs * test(security): exercise malformed webhook bodies at API boundary * π‘οΈ Sentinel: [CRITICAL] Fix stored SSRF and Uncaught Exception in webhook URL endpoint - /api/v1/webhook μλν¬μΈνΈμμ μ¬μ©μλ‘λΆν° μ λ¬λ°μ webhook urlμ κ²μ¦ μμ΄ λ°μ΄ν°λ² μ΄μ€μ μ μ₯νλ μ·¨μ½μ μ΄ λ°κ²¬λμ΄, μ μ₯ μ _is_safe_url() ν¨μλ‘ κ²μ¦νλλ‘ μμ νμ΅λλ€. - _is_safe_url() λ΄λΆμμ urllib.parse.urlparse() μ¬μ© μ λ¬Έμμ΄ νμ νμΈ λ‘μ§(isinstance(url, str))μ μΆκ°νμ¬ μ μνμ΄λ λΆλ¦¬μΈ λ± μλͺ»λ νμ μ΄ μ λ ₯λ λ μλ² μλ¬(500) λμ μμ νκ² μ°¨λ¨λλλ‘ μμ νμ΅λλ€. - κ²μ¦μ μ€ν¨ν μ 400 μλ¬λ₯Ό μλ΅νλ©° κ΄λ ¨ ν μ€νΈ μ½λλ₯Ό μ λ°μ΄νΈ/μΆκ°νμ΅λλ€. * test(scanner): reproduce stored SSRF detection gap * security(scanner): detect direct stored webhook SSRF * test(controlplane): pin webhook input validation boundary * fix(controlplane): reject malformed webhook payloads * test(controlplane): prove invalid webhook input preserves state * test(scanner): expose stored SSRF variable-flow blind spot * fix(scanner): detect unvalidated stored SSRF variable flow * test(scanner): expose SSRF finding metadata misclassification * fix(scanner): classify CWE-918 findings as SSRF * test(scanner): expose stored SSRF rule evasion paths * fix(scanner): close stored SSRF rule evasion paths * test(scanner): expose non-enforcing SSRF guard bypass * test(scanner): pin fail-closed SSRF guard semantics * fix(scanner): require enforcing SSRF validation guards * docs(tests): document stored SSRF regression contracts * test(scanner): expose equivalent stored SSRF accessors * fix(scanner): detect equivalent stored SSRF accessors * docs(tests): document webhook validation helpers * perf(scanner): prefilter stored SSRF rule by sink literal Avoid evaluating the bounded but expensive flow regex in Python files that cannot persist a webhook. Preserve exact detection semantics while reducing a 1 MiB sink-free scan from seconds to a linear literal check. * fix(scanner): accept none-aware fail-closed SSRF guard * π¨ Palette: κ°μ λ νμΌ μ λ‘λ λ²νΌ UX μ μ© (#925) * feat(dashboard): κ°μ λ νμΌ μ λ‘λ UXλ₯Ό μν νλ‘μ λ²νΌ μΆκ° Dashboardμ λ€μ΄ν°λΈ νμΌ μ λ‘λ μΈνμ μ¨κΈ°κ³ μ€νμΌ μ μ΄κ° κ°λ₯ν νλ‘μ λ²νΌμΌλ‘ κ΅μ²΄νμ¬ UI μΌκ΄μ±μ ν₯μμμΌ°μ΅λλ€. - λ€μ΄ν°λΈ `<input type="file">`μ `sr-only` λ±μ ν΅ν΄ μ κ·Όμ±μ μ μ§ν μ± μκ°μ μΌλ‘λ§ μ¨κΉ μ²λ¦¬ - `.tag` ν΄λμ€λ₯Ό νμ©ν μλ‘μ΄ μ λ‘λ νλ‘μ `<button>` μΆκ° - λ¨μΌ νμ΄μ§ μ ν리μΌμ΄μ (SPA)μμ λμΌ νμΌ μ°μ μ ν μ λΈλΌμ°μ κ° `change` μ΄λ²€νΈλ₯Ό 무μνλ λ¬Έμ ν΄κ²° (JSμμ νμΌ μΊ‘μ² ν `value` μ΄κΈ°ν) - κ΄λ ¨ UX νμ΅ λ΄μ©μ `.jules/palette.md`μ μΆκ° - λ³κ²½ μ¬νμ λ§κ² νλ‘ νΈμλ UI 컨νΈλνΈ ν μ€νΈ μ λ°μ΄νΈ * test(dashboard): lock accessible upload proxy wiring --------- Co-authored-by: seonghobae <8172694+seonghobae@users.noreply.github.com> --------- Co-authored-by: seonghobae <8172694+seonghobae@users.noreply.github.com>
Palette UX κ°μ : νμΌ μ λ‘λ λ²νΌ μΌκ΄μ± ν₯μ π¨
π‘ What
Dashboard UIμμ λΈλΌμ°μ κΈ°λ³Έ
<input type="file">μ μ¨κΈ°κ³ , κΈ°μ‘΄μ.tagλμμΈ ν΄λμ€λ₯Ό νμ©ν νλ‘μ λ²νΌ(<button id="header-browse">Upload findings</button>)μ λμ νμ΅λλ€.π― Why
findings.json)μ μ°μμΌλ‘ λ€μ μ λ‘λνλ €κ³ ν λ λΈλΌμ°μ κ°changeμ΄λ²€νΈλ₯Ό λ°μμν€μ§ μμ UIκ° λ°μνμ§ μλ λ¬Έμ κ° λ°μν μ μμ΅λλ€. νλ‘μ λ²νΌμ μ¬μ©νκ³ μ€ν¬λ¦½νΈμμ λͺ μμ μΌλ‘valueλ₯Ό λΉμμ€μΌλ‘μ¨ μ΄ λ¬Έμ λ₯Ό κ·Όλ³Έμ μΌλ‘ ν΄κ²°νμ΅λλ€.βΏ Accessibility
<input type="file">μ DOMμμ μ κ±°νμ§ μκ³sr-only,tabindex="-1",aria-hidden="true"λ₯Ό μ μ©νμ¬ μ€ν¬λ¦° 리λμμ μ€λ³΅μΌλ‘ μ½νλ κ²μ λ°©μ§νλ©΄μ κΈ°λ₯μ μ μ§νμ΅λλ€.test_dashboard_rows_are_keyboard_accessibleμ μ€λλ aria-label κ²μ¦ μ½λλ₯Ό μμ νκ² μ λ°μ΄νΈνμμ΅λλ€.πΈ Before/After
(μμ μ ) κΈ°λ³Έ λΈλΌμ°μ μ€νμΌμ νμΌ μ λ‘λ λ²νΌ λ ΈμΆ
(μμ ν) ν€λμ λμμΈ ν ν°(
.tag)μ μ΄μΈλ¦¬λ ν μ€νΈ ννμ νλ‘μ λ²νΌ λ ΈμΆPR created automatically by Jules for task 10910099905014635097 started by @seonghobae